This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG002bfdd6b119: [clang][modules] Track affecting modules
(authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D132430?vs=45
jansvoboda11 updated this revision to Diff 454979.
jansvoboda11 added a comment.
Backslashes in tests on Windows
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132430/new/
https://reviews.llvm.org/D132430
Files:
clang/include/clang/Basic/Module.h
jansvoboda11 updated this revision to Diff 454975.
jansvoboda11 added a comment.
Add `-fmodule-file=` assertions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132430/new/
https://reviews.llvm.org/D132430
Files:
clang/include/clang/Basic/Module.h
benlangmuir added inline comments.
Comment at: clang/test/ClangScanDeps/modules-incomplete-umbrella.c:82
+// CHECK_TU-NEXT: "command-line": [
+// CHECK_TU:],
+// CHECK_TU-NEXT: "file-deps": [
jansvoboda11 wrote:
> benlangmuir wrote:
> > Th
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:311
+if (!MDC.isPrebuiltModule(M))
+ DirectModularDeps.insert(M);
+
benlangmuir wrote:
> If using eager loading, this will cause us to load the mo
benlangmuir added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:311
+if (!MDC.isPrebuiltModule(M))
+ DirectModularDeps.insert(M);
+
If using eager loading, this will cause us to load the module, right? Does that
jansvoboda11 created this revision.
jansvoboda11 added reviewers: benlangmuir, Bigcheese.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When compiling a module, its semantics and Clang's behavior
