[PATCH] D132400: [clang] Remove a FIXME that we can't fix

2022-08-23 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Thanks, fixed commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132400/new/ https://reviews.llvm.org/D132400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

2022-08-23 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd24120c9d95: [clang] Remove a FIXME that we can't fix (authored by thakis). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

2022-08-23 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm "No behavior change." occurs twice in the change description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132400/new/ https://reviews.llvm.org/D132400 ___

[PATCH] D132400: [clang] Remove a FIXME that we can't fix

2022-08-22 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: hans. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. thakis requested review of this revision. Herald added a subscriber: MaskRay. I added this recently, but it looks like several tests very intentionally check