This revision was automatically updated to reflect the committed changes.
Closed by commit rG94778692ad25: [clang] Add support for
__attribute__((guard(nocf))) (authored by alvinhochun, committed by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D132302?vs=454798&id=454944#toc
Re
alvinhochun updated this revision to Diff 454798.
alvinhochun marked an inline comment as done.
alvinhochun added a comment.
Rebased and added a release note entry. @mstorsjo would you mind landing this
for me? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Please be sure to add a release note when you land (we have a section
about changes to attributes).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
alvinhochun updated this revision to Diff 454559.
alvinhochun edited the summary of this revision.
alvinhochun added a comment.
Applied suggestions from Aaron. Thanks for the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132302/new/
https:
aaron.ballman added a comment.
There should be some explicit test coverage that show the new attribute
spelling(s) work when spelled directly rather than when relying on predefined
macros.
Comment at: clang/include/clang/Basic/Attr.td:3496
// we might also want to support
alvinhochun updated this revision to Diff 454280.
alvinhochun added a comment.
Specify x86_64-w64-windows-gnu in tests instead of using %itanium_abi_triple
because it doesn't work on Linux.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132302/new/
alvinhochun created this revision.
Herald added subscribers: pengfei, mstorsjo.
Herald added a reviewer: aaron.ballman.
Herald added a project: All.
alvinhochun added reviewers: ajpaverd, rnk.
alvinhochun updated this revision to Diff 454274.
alvinhochun edited the summary of this revision.
alvinho
