[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-23 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG083e3a173d9e: [clang-tidy] Skip unions in use-equals-default (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-22 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexander-shaposhnikov updated this revision to Diff 454470. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/ https://reviews.llvm.org/D132290 Files: clang-tools-extra/clang-tidy/

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-20 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/use-equals-default-copy.cpp:38 + NU(const NU &Other) : Field(Other.Field) {} + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:3: warning: use '= default' + // CHECK-FIXES: NU(const NU &Other

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-20 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Please mention changes in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132290/new/ https://reviews.llvm.org/D132290 ___ cfe-commits mailing list cfe-commit

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-20 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:221 // Destructor. - Finder->addMatcher(cxxDestructorDecl(isDefinition()).bind(Sp

[PATCH] D132290: [clang-tidy] Skip unions in use-equals-default

2022-08-20 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: aaron.ballman, asoffer. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-shaposhnikov requested rev