Re: [PATCH] D13228: clang-format: Extend #include sorting functionality

2015-09-29 Thread Daniel Jasper via cfe-commits
djasper closed this revision. djasper added a comment. Submitted as r248782. http://reviews.llvm.org/D13228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13228: clang-format: Extend #include sorting functionality

2015-09-29 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D13228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D13228: clang-format: Extend #include sorting functionality

2015-09-29 Thread Daniel Jasper via cfe-commits
djasper marked an inline comment as done. Comment at: lib/Format/Format.cpp:1677 @@ +1676,3 @@ +unsigned Category; +if (LookForMainHeader &&! Matches[1].startswith("<")) { + Category = 0; klimek wrote: > Run clang-format. > > Also, should

Re: [PATCH] D13228: clang-format: Extend #include sorting functionality

2015-09-29 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: lib/Format/Format.cpp:1665 @@ +1664,3 @@ + + // Create pre-compile regular expressions for the #include categories. + SmallVector CategoryRegexs; pre-compiled Comment at: lib/Format/Format.cpp:1677 @@ +

[PATCH] D13228: clang-format: Extend #include sorting functionality

2015-09-28 Thread Daniel Jasper via cfe-commits
djasper created this revision. djasper added a reviewer: klimek. djasper added a subscriber: cfe-commits. Herald added a subscriber: klimek. Recognize main module header as well as different #include categories. This should now mimic the behavior of llvm/utils/sort_includes.py as well as clang-t