This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf7dc91ad5609: [pseudo] Eliminate a false parse of structured
binding declaration. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANG
hokein updated this revision to Diff 454816.
hokein marked 3 inline comments as done.
hokein added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132260/new/
https://reviews.llvm.org/D132260
Files:
clang-tools-extra/ps
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/pseudo/lib/cxx/CXX.cpp:164
+bool isStructuredBinding(const ForestNode* N) {
+ assert(N->symbol() == Symbol::decl_specifier_seq);
--
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: All.
hokein requested review of this revision.
Herald added a subscriber: alextsao1999.
Herald added a project: clang-tools-extra.
Using the guard to implement part of the rule https://eel.is/c++draft/dcl.pre
