[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f6cb3e9fdb4: [AMDGPU] Add builtin s_sendmsg_rtn (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/ne

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

yaxunl updated this revision to Diff 454607. yaxunl added a comment. remove unnecessary tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/lib/CodeGen/CGBuiltin.cpp clang/test/

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

yaxunl added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23 + +// Test mismatched argument and return types are handled. + tra wrote: > Is there a particular reason for this test? > > Argument and return value type checks shoul

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

tra added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-gfx11.cl:23 + +// Test mismatched argument and return types are handled. + Is there a particular reason for this test? Argument and return value type checks should've been handled by

[PATCH] D132140: [AMDGPU] Add builtin s_sendmsg_rtn

b-sumner added a comment. In D132140#3732337 , @yaxunl wrote: > revised by Brian's comments Thank you. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132140/new/ https://reviews.llvm.org/D132140 _