This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0e0e8b65765e: Do not evaluate dependent immediate
invocations (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
usaxena95 updated this revision to Diff 453562.
usaxena95 marked 2 inline comments as done.
usaxena95 added a comment.
Updated release notes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132031/new/
https://reviews.llvm.org/D132031
Files:
clang
ilya-biryukov added a comment.
A few NITS for the release notes, otherwise LG
Comment at: clang/docs/ReleaseNotes.rst:162
(C++14 [dcl.constexpr]p6 (CWG DR647/CWG DR1358))
+- Correctly defer dependent immediate invocations until template instantiation.
+ This fixes `Issue 55
usaxena95 added a comment.
Addressed comments. Added release note.
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:665
+Bar f;
+Bar g;
+} // namespace issue_55601
aaron.ballman wrote:
> Do you think it's worth it to add a test case like:
> ```
> struct derp
usaxena95 updated this revision to Diff 453526.
usaxena95 marked an inline comment as done.
usaxena95 edited the summary of this revision.
usaxena95 added a comment.
Addressed comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132031/new/
http
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Thank you, this LGTM, though I did have a testing question. Also, please be
sure to add a release note for the fix.
Comment at: clang/test/SemaCXX/cxx2a-conste
usaxena95 created this revision.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We deferred the evaluation of dependent immediate invocations in
https://reviews.llvm.org/D119375.
We should also not c
