[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske abandoned this revision. balazske added a comment. A new solution is in D135247 . The new approach is that only `StdLibraryFunctionsChecker` adds the errno modeling part, together with other checks (that are applicable if StreamChecker is turned off) f

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:465 + /// post-call event. + class NoErrnoConstraint : public ErrnoConstraintBa

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske added a reviewer: martong. balazske added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:537 + errno_modeling::getNoteTagForStdSuccess( + C, cast(Call.getDecl())-

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske updated this revision to Diff 454026. balazske marked 2 inline comments as done. balazske added a comment. - Use `Optional` for `EofInitialized` - Split tests into two files with and without note check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske updated this revision to Diff 453297. balazske added a comment. StdLibraryFunctionsChecker should not overwrite errno constraints that are set by StreamChecker. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132017/new/ https://reviews.llvm

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:283-284 + mutable bool EofInitialized = false; + mutable int EofVal = -1; + Have you considered using `llvm::Optional` for this? Comment at: cla

[PATCH] D132017: [clang][analyzer] Add errno modeling to StreamChecker

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project: