[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a5470fc249: [clang][Interp] Implement boolean and nullptr literals (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131942/new/ https:

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3729379 , @tbaeder wrote: > In D131942#3729057 , @aaron.ballman > wrote: > >> In D131942#3728994 , @erichkeane >> wrote: >> >>>

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

tbaeder added a comment. In D131942#3729057 , @aaron.ballman wrote: > In D131942#3728994 , @erichkeane > wrote: > >> In D131942#3728974 , >> @aaron.ballman wrote: >> >>

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman added a comment. In D131942#3728994 , @erichkeane wrote: > In D131942#3728974 , @aaron.ballman > wrote: > >> LGTM as well; should we add a release note for this? I suspect not because >> it's impr

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane added a comment. In D131942#3728974 , @aaron.ballman wrote: > LGTM as well; should we add a release note for this? I suspect not because > it's improving an experimental feature that's not really ready for prime time > yet, but I don't know

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM as well; should we add a release note for this? I suspect not because it's improving an experimental feature that's not really ready for prime time yet, but I don't know how others feel. CHANGES SINCE LAST ACTION https

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, -

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { +

[PATCH] D131942: [clang][Interp] Implement bool and nullptr literal expressions

erichkeane added inline comments. Comment at: clang/lib/AST/Interp/Disasm.cpp:26 inline std::enable_if_t::value, T> ReadArg(Program &P, - CodePtr OpPC) { +