This revision was automatically updated to reflect the committed changes.
Closed by commit rGdbb95c2a851c: [clang][dataflow] Debug string for value
kinds. (authored by wyt).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131891/new/
https://reviews.l
wyt updated this revision to Diff 452968.
wyt added a comment.
Use llvm::StringRef for returning static strings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131891/new/
https://reviews.llvm.org/D131891
Files:
clang/include/clang/Analysis/FlowS
xazax.hun added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:34
+std::string debugString(Value::Kind Kind) {
+ switch (Kind) {
I think all of these `debugString` functions could return a `llvm::StringRef`
or an `std::string_v
wyt created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
wyt requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.l
