This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2efc8f8d6561: [clang][dataflow] Add an option for
context-sensitive depth (authored by samestep).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
samestep updated this revision to Diff 452783.
samestep added a comment.
Address Stanislav's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131809/new/
https://reviews.llvm.org/D131809
Files:
clang/include/clang/Analysis/FlowSensitive/Da
samestep added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:665
+if (!(Options.ContextSensitiveOpts &&
+ Env.canDescend(Options.ContextSensitiveOpts->Depth, F)))
return;
samestep wrote:
> xazax.hun wrote:
> > Alte
samestep added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:210
+ const DeclContext *Callee) const {
+ return CallString.size() <= MaxDepth &&
+ std::find(CallString.begin(), CallString.end(), Callee) =
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Once the Stanislav's comments are resolved, it looks good to me.
Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:665
+if (!(Options.ContextSensitiveOpts &
sgatev added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:395
// `DeclContext` of the block being analysed if provided.
- const DeclContext *DeclCtx = nullptr;
+ std::vector CallString;
C
samestep created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
samestep requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https:/
