[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad2e6c830de: [HLSL] clang codeGen for HLSLNumThreadsAttr (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://revie

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 ___ c

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 461146. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/test/CodeGenHLSL/

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 460288. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/test/CodeGenHLSL/

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 455954. python3kgae added a comment. Fix build error and merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRuntime.

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 454051. python3kgae marked 2 inline comments as done. python3kgae added a comment. Use llvm::formatv. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: cla

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:103 + << NumThreadsAttr->getZ(); +OS.flush(); +F->addFnAttr(NumThreadsKindStr, NumThreadsStr); You can replace this whole chunk of code with: ``` std::string NumThreadsStr

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae updated this revision to Diff 452305. python3kgae added a comment. Change attribute name to hlsl.numthreads Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131799/new/ https://reviews.llvm.org/D131799 Files: clang/lib/CodeGen/CGHLSLRun

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

beanz added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:98 + if (HLSLNumThreadsAttr *NumThreadsAttr = FD->getAttr()) { +const StringRef NumThreadsKindStr = "dx.numthreads"; +std::string NumThreadsStr; This isn't DirectX-specific, so

[PATCH] D131799: [HLSL] clang codeGen for HLSLNumThreadsAttr

python3kgae created this revision. python3kgae added reviewers: bogner, beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Translate HLSLNumThreadsA