[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8578968f684: [ADT] Replace STLForwardCompat.h's C++17 equivalents (authored by joe_loser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131717/new/ https:

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser updated this revision to Diff 452022. jloser added a comment. Fix unqualified use of `in_place` so the delegating constructor in `Optional` calls the one taking the `std::in_place_t` tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131717/

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

scott.linder accepted this revision. scott.linder added a comment. LGTM, thank you! I have some pending changes which would add C++20 "compat" types, but removing it until those land sounds fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser added a comment. In D131717#3717363 , @MaskRay wrote: > The llvm/include/llvm/ADT/STLForwardCompat.h and > llvm/unittests/ADT/STLForwardCompatTest.cpp removal can be in a separate > patch. Sure. I just split them out of this patch and I'll do th

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser updated this revision to Diff 451977. jloser added a comment. Revert removal of these utilities and type traits from STLForwardCompat.h and their corresponding unit tests. The removal of these will be done in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. The llvm/include/llvm/ADT/STLForwardCompat.h and llvm/unittests/ADT/STLForwardCompatTest.cpp removal can be in a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D131717: [ADT] Replace STLForwardCompat.h's C++17 equivalents

jloser created this revision. jloser added reviewers: scott.linder, MaskRay, bkramer, zero9178, dblaikie. Herald added a subscriber: StephenFan. Herald added a project: All. jloser requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-com