[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. In D131665#3740037 , @phosek wrote: > LGTM @phosek Thanks for your review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c6c4f6a9b3e: [CMake] Support passing arguments to build tool (bootstrap). (authored by CarlosAlbertoEnciso). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 ___

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

andrewng resigned from this revision. andrewng added a comment. Resign as reviewer as I also work with Carlos and helped to author this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 _

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

russell.gallop resigned from this revision. russell.gallop added a comment. Resign as reviewer as I work with Carlos (and am not familiar enough with the details of this area). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://revi

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso added a comment. To give more scope to the reviewers, the following CMake options illustrate the benefit of this patch. For example, if I want to do a dry run on stage-2, I will pass `-DLLVM_EXTERNAL_PROJECT_BUILD_TOOL_ARGS="-n --verbose"` -DCLANG_ENABLE_BOOTSTRAP=ON -DLL

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

russell.gallop added a comment. Noting related review: https://reviews.llvm.org/D115815 which added this variable to support this for other "external projects". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D13

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

CarlosAlbertoEnciso created this revision. CarlosAlbertoEnciso added reviewers: andrewng, phosek, beanz, russell.gallop. CarlosAlbertoEnciso added a project: LLVM. Herald added a subscriber: mgorny. Herald added a project: All. CarlosAlbertoEnciso requested review of this revision. Herald added a p