This revision was automatically updated to reflect the committed changes.
stuij marked an inline comment as done.
Closed by commit rG27cbfa7cc8cd: [Clang] Propagate const context info when
emitting compound literal (authored by stuij).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACT
DavidSpickett accepted this revision.
DavidSpickett added a comment.
My comment was addressed, LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131555/new/
https://reviews.llvm.org/D131555
___
cfe-com
stuij marked an inline comment as done.
stuij added inline comments.
Comment at: clang/test/CodeGen/const-init.c:2
+// setting strict FP behaviour in the run line below tests that the compiler
+// does the right thing for global compound literals (compoundliteral test)
+// RUN: %
stuij updated this revision to Diff 453579.
stuij added a comment.
addressed review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131555/new/
https://reviews.llvm.org/D131555
Files:
clang/lib/CodeGen/CGExprConstant.cpp
clang/lib/CodeGe
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
This seems reasonable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131555/new/
https://reviews.llvm.org/D131555
_
DavidSpickett added inline comments.
Comment at: clang/test/CodeGen/const-init.c:2
+// setting strict FP behaviour in the run line below tests that the compiler
+// does the right thing for global compound literals (compoundliteral test)
+// RUN: %clang_cc1 -no-opaque-pointers -t
stuij marked 2 inline comments as done.
stuij added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217
assert(E->isFileScope() && "not a file-scope compound literal expr");
- return tryEmitGlobalCompoundLiteral(*this, nullptr, E);
+ ConstantEmitter emitte
stuij updated this revision to Diff 451794.
stuij added a comment.
addressed review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131555/new/
https://reviews.llvm.org/D131555
Files:
clang/lib/CodeGen/CGExprConstant.cpp
clang/lib/CodeGe
vhscampos added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217
assert(E->isFileScope() && "not a file-scope compound literal expr");
- return tryEmitGlobalCompoundLiteral(*this, nullptr, E);
+ ConstantEmitter emitter(*this, nullptr);
+ return tryEmit
vhscampos added inline comments.
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:2217
assert(E->isFileScope() && "not a file-scope compound literal expr");
- return tryEmitGlobalCompoundLiteral(*this, nullptr, E);
+ ConstantEmitter emitter(*this, nullptr);
+ return tryEmit
stuij updated this revision to Diff 451783.
stuij marked an inline comment as done.
stuij added a comment.
also added a comment above the runline. Initially thought it wouldn't be
necessary as we're now doing a check, but I do agree that it's more clear to be
specific about the cmdline arg.
Re
stuij updated this revision to Diff 451781.
stuij added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131555/new/
https://reviews.llvm.org/D131555
Files:
clang/lib/CodeGen/CGExprConstant.cpp
clang/lib/CodeG
simon_tatham added a comment.
The clang code change looks reasonable to me, but I'm not the most expert in
that area.
The intended result certainly seems sensible, because the C90-compatible
version of that code //without// a constant literal is happy to do doubleāfloat
conversion at compile t
stuij created this revision.
Herald added a project: All.
stuij requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch fixes a crash when trying to emit a constant compound literal.
For C++ Clang evaluates either casts or binary operat
14 matches
Mail list logo
