[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

stephanemoore added a comment. LGTM after fixing the assertion ✅ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a comment. In D131424#3828656 , @mwyman wrote: > In D131424#3828647 , @ahatanak > wrote: > >> `-fobjc-arc` is needed to see the assertion fail. > > Oops, yep I'll send a patch. Sent https://reviews.

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a comment. In D131424#3828647 , @ahatanak wrote: > `-fobjc-arc` is needed to see the assertion fail. Oops, yep I'll send a patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ htt

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak added a comment. `-fobjc-arc` is needed to see the assertion fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-com

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak added a comment. It looks like this patch causes an assertion to fail (`Assertion failed: (it != LocalDeclMap.end() && "Invalid argument to GetAddrOfLocalVar(), no decl!")`) when the following code is compiled. __attribute__((objc_direct_members)) @interface C @property id prop;

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa4bcaab9600: Remove the unused/undefined `_cmd` parameter in `objc_direct` methods. (authored by mwyman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1314

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commi

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. In D131424#3803190 , @mwyman wrote: > Hi Akira, > > I'd reached out to John offline and he'd mentioned you might be able to help > on some of these objc_direct reviews; if so, that would be wonderful! > > -Michael I would also be

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a reviewer: ahatanak. mwyman added a comment. Hi Akira, I'd reached out to John offline and he'd mentioned you might be able to help on some of these objc_direct reviews; if so, that would be wonderful! -Michael CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ h

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman added a comment. This is related to changes for https://reviews.llvm.org/D86049. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman updated this revision to Diff 451051. mwyman added a comment. Fixed assert due to mis-matched number of expected parameters. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGObj

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. Updated D86049 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131424/new/ https://reviews.llvm.org/D131424 ___ cfe-commits mailing list cfe-commi

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:487 SmallVector argTys; SmallVector extParamInfos(2); argTys.push_back(Context.getCanonicalParamType(receiverType)); In order to fix the assert try this instead on line 487: ``` Sm

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

plotfi added a comment. I tried running the following on some example code and got a stacktrace: // RUN: clang -cc1 -no-opaque-pointers -emit-llvm -fobjc-arc -triple x86_64-apple-darwin10 -o - %s -O0 @interface C - (int)getInt __attribute__((objc_direct)); @end @implementation C

[PATCH] D131424: Remove the unused/undefined _cmd parameter to objc_direct methods.

mwyman created this revision. mwyman added reviewers: dmaclach, plotfi. mwyman added a project: clang. Herald added a project: All. mwyman requested review of this revision. Herald added a subscriber: cfe-commits. When `objc_direct` methods were implemented, the implicit `_cmd` parameter was left