[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e207e4c096e: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue} (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3708542 , @dblaikie wrote: > Sounds good - I'd be probably OK with removing these outright as they're so > niche/generally only for use by `llvm::Optional` anyway - but not much harm > in keeping them around for the same

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - I'd be probably OK with removing these outright as they're so niche/generally only for use by `llvm::Optional` anyway - but not much harm in keeping them around for the same

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. PTAL. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu updated this revision to Diff 451002. kazu added a comment. Updated to use LLVM_DEPRECATED instead of [[deprecated]]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 Files: clang/include/clang/Basi

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu added a comment. In D131368#3707265 , @dblaikie wrote: > Update this to use something like https://reviews.llvm.org/D131381 ? Great idea! Will do! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

dblaikie added a comment. Update this to use something like https://reviews.llvm.org/D131381 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131368/new/ https://reviews.llvm.org/D131368 ___ cfe-commits m

[PATCH] D131368: [Basic] Deprecate MapEntryOptionalStorage::{hasValue,getValue}

kazu created this revision. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MapEntryOptionalStorage is an underlying storage class for OptionalStorage. This patch deprecates: OptionalStorage::hasValue