This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b52341116b7: [CUDA] Fix output name being replaced in
device-only mode (authored by jhuber6).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131278/new/
htt
jhuber6 added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:148
+// RUN: | FileCheck -check-prefix=D_ONLY %s
+// D_ONLY: "foo.o"
tra wrote:
> jhuber6 wrote:
> > tra wrote:
> > > Ideally we want to test that the output file actually survives the
tra added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:148
+// RUN: | FileCheck -check-prefix=D_ONLY %s
+// D_ONLY: "foo.o"
jhuber6 wrote:
> tra wrote:
> > Ideally we want to test that the output file actually survives the
> > compilation. It'
jhuber6 added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:148
+// RUN: | FileCheck -check-prefix=D_ONLY %s
+// D_ONLY: "foo.o"
tra wrote:
> Ideally we want to test that the output file actually survives the
> compilation. It's traky to do for
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
I can confirm that this patch fixes the issue.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131278/new/
https://reviews.llvm.org/D131278
___
tra added inline comments.
Comment at: clang/test/Driver/cuda-bindings.cu:148
+// RUN: | FileCheck -check-prefix=D_ONLY %s
+// D_ONLY: "foo.o"
Ideally we want to test that the output file actually survives the compilation.
It's traky to do for in-tree tests as w
jhuber6 created this revision.
jhuber6 added a reviewer: tra.
Herald added subscribers: mattd, yaxunl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
When performing device only compilation, the
