[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet added a comment. In D131214#3733317 , @thakis wrote: > The removal of the explicit target broke the test on Mac: > http://45.33.8.238/macm1/42754/step_7.txt > > (Just need to be more permissive about leading underscores) > > Please take a look a

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

thakis added a comment. The removal of the explicit target broke the test on Mac: http://45.33.8.238/macm1/42754/step_7.txt (Just need to be more permissive about leading underscores) Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. abrachet marked an inline comment as done. Closed by commit rG377dddf4a083: [clang][Driver] Pass correct reproduce flag to lld-link (authored by abrachet). Herald added

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! LG with comment. Comment at: clang/lib/Driver/Driver.cpp:1638 llvm::opt::ArgStringList ArgList = NewLLDInvocation.getArguments(); -ArgList.push_back(Saver.sa

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet marked 2 inline comments as done. abrachet added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1639 +Twine ReproduceOption = +C.getDefaultToolChain().getTriple().isOSBinFormatCOFF() +? "/reproduce:" mstorsjo wrote: > th

[PATCH] D131214: [clang][Driver] Pass correct reproduce flag to lld-link

abrachet updated this revision to Diff 450836. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131214/new/ https://reviews.llvm.org/D131214 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/lld-repro.c Index: clang/test/Driver/lld-repro.c ==