This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8611a77ee7ee: [clang][dataflow] Analyze method bodies
(authored by samestep).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
ymandel accepted this revision.
ymandel added a comment.
Nice!!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131170/new/
https://reviews.llvm.org/D131170
___
cfe-commits mailing list
cfe-commits@lists.l
sgatev added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217
+const Expr *Arg = MethodCall->getImplicitObjectArgument();
+Env.ThisPointeeLoc = Env.getStorageLocation(*Arg, SkipPast::Reference);
+ }
samestep wrote
samestep added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217
+const Expr *Arg = MethodCall->getImplicitObjectArgument();
+Env.ThisPointeeLoc = Env.getStorageLocation(*Arg, SkipPast::Reference);
+ }
sgatev wrote
sgatev accepted this revision.
sgatev added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:217
+const Expr *Arg = MethodCall->getImplicitObjectArgument();
+Env.ThisPointeeLoc = Env.get
samestep updated this revision to Diff 449986.
samestep added a comment.
Address Stanislav's comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131170/new/
https://reviews.llvm.org/D131170
Files:
clang/include/clang/Analysis/FlowSensitive/Da
samestep added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:383
StorageLocation *ReturnLoc = nullptr;
- // FIXME: Move `ThisPointeeLoc` here from `DataflowAnalysisContext`.
+ StorageLocation *ThisPointeeLoc = nullptr;
--
sgatev added inline comments.
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:383
StorageLocation *ReturnLoc = nullptr;
- // FIXME: Move `ThisPointeeLoc` here from `DataflowAnalysisContext`.
+ StorageLocation *ThisPointeeLoc = nullptr;
samestep created this revision.
Herald added subscribers: martong, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
samestep requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https:/
