[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11ec00afea3: FoldingRanges: Handle LineFoldingsOnly clients. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://rev

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 __

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456335. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-to

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:254 +// Remove the ending sentinal "*/" from the block comment range. +if (Code.substr(EndOffset(*LastComment) - 2, 2) == "*/") { + End.character -= 2; this is

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456321. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tool

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:202 FR.endLine = End.line; +FR.startCharacter = Start.character; FR.endCharacter = End.character; can you put it back to its previous location (i.e. right aft

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:391 +/* No folding for this comment. +*/ int b_token=0; + )cpp", kadircet wrote: > it'd be nice to have a test case like: > ``` > templ

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 455920. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-t

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:225 + Position End) { +// For LineFoldingsOnly clients, do not fold the last line if it +// contains tokens after `End`. hokei

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

hokein added a comment. In D131154#3706062 , @kadircet wrote: > thanks, i think we should change the behaviour to not fold the last line in > any case. +1, I think we should always do it for all bracket cases, but we probably don't want it for other ca

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

kadircet added a comment. thanks, i think we should change the behaviour to not fold the last line in any case. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:943 Callback> Reply) { - Server->foldingRanges(Params.textDocument.uri.file(), std::move(Reply)); + S

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449931. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-e

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449928. usaxena95 added a comment. Do same for multi-line comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServe

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Do not fold the endline wh