[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover closed this revision. t.p.northover added a comment. Just noticed it'd already been approved with those suggestions, so pushed the revised version: 4388b56d and 58f9abaed4aa

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 459004. t.p.northover marked an inline comment as done. t.p.northover added a comment. Switched to `enum class`. > You may want to split the patch, with refactoring as the first, and the > Mach-O specific change as the second one. I've got it split in

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. You may want to split the patch, with refactoring as the first, and the Mach-O specific change as the second one. Comment at: clang/

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 458444. t.p.northover added a comment. Herald added subscribers: bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, mgester, arpith-ja

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover updated this revision to Diff 458443. Herald added subscribers: abrachet, mstorsjo, emaste. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131153/new/ https://reviews.llvm.org/D131153 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/li

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover added a comment. > I don't think this is quite correct though? It'll turn off unwind tables for > AArch64 entirely, whereas we want to keep sync unwind tables. You're right, sorry about that. Hopefully this refactoring with MaskRay's suggestion gets it right. C

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

MaskRay added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:501 + /// IsAsyncUnwindTablesDefault - Does this tool chain use + /// -fasync-unwind-tables by default. + virtual bool smeenai wrote: > I believe the option is spelled `-fasynchr

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

smeenai added a comment. I just discovered this and was about to post on Discourse about it. Glad you're already on it :) I don't think this is quite correct though? It'll turn off unwind tables for AArch64 entirely, whereas we want to keep sync unwind tables. If we want to minimize changes to

[PATCH] D131153: AArch64: disable asynchronous unwind by default for MachO.

t.p.northover created this revision. Herald added subscribers: kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. AArch64 MachO has a compact unwind format where most functions' u