[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:64-67 +Terms enclosed in ``[]`` are optional. The syntax of ``module_name`` and ``partition_name`` +in regex form corresponds to ``[a-zA-Z_][a-zA-Z_0-9\.]*``. The dot ``.`` in the name has +no speci

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Let's review it in https://reviews.llvm.org/D131388 later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 ___ cfe-commits mailing list

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differe

[PATCH] D131062: [docs] Add "C++20 Modules"

iains added a comment. @h-vetinari you are right, this has become difficult to review - I will try and do some more later - just the one comment for now. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang mo

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differ

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:676-678 +So the final answer for why we don't reuse the interface of Clang modules for header units is that +we've see some differences between header units and Clang modules and we think the differe

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. If you do open a new revision, please also consider breaking the lines at a length that phabricator doesn't overflow (seems to be 122 characters), and change all occurrences of "codes" to "code". Comment at: clang/docs/CPlusPlus20Modules.rst:676-67

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. In D131062#3705864 , @ChuanqiXu wrote: > Yeah, I am also worrying if the comments may block other reviewers to review. > Do you know any method to ignore these comments in phab? If not, I guess I > need to create a new page (

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. In D131062#3705767 , @h-vetinari wrote: > It gets very confusing that phab now attaches the old review comments in the > wrong place. Yeah, I am also worrying if the comments may block other reviewers to review. Do you know

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 450731. ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 Files: clang/docs/CPlusPlus20Modules.rst clang/docs/in

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu marked 8 inline comments as done. ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:316-317 + +Currently Clang would accept the above example. But it may produce surprising results if the +debugging code depends on consistent use of ``NDEBU

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. It gets very confusing that phab now attaches the old review comments in the wrong place. Comment at: clang/docs/CPlusPlus20Modules.rst:22 +different semantics, it might be more friendly for users who care about C++20 +modules only to create a new p

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 450692. ChuanqiXu marked 8 inline comments as done. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131062/new/ https://reviews.llvm.org/D131062 Files: clang/docs/CPlusPlus20Modules.rst clang/docs/in

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a reviewer: h-vetinari. ChuanqiXu marked 45 inline comments as done. ChuanqiXu added a comment. In D131062#3704017 , @h-vetinari wrote: >> It would be greatly welcome for such comments! > > OK, here goes. Sorry for the large volume of com

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. > It would be greatly welcome for such comments! OK, here goes. Sorry for the large volume of comments. In addition to typos and stylistic improvements, I've had a few questions where the content wasn't clear to me (but note I'm not experienced with modules at all, s

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. In D131062#3699341 , @h-vetinari wrote: > Aside from a couple typos, I was wondering if it would be welcome to do a > pass w.r.t stylistic improvements (e.g. "Modules have a lot of meanings." --> > "The term 'modules' has a l

[PATCH] D131062: [docs] Add "C++20 Modules"

h-vetinari added a comment. Aside from a couple typos, I was wondering if it would be welcome to do a pass w.r.t stylistic improvements (e.g. "Modules have a lot of meanings." --> "The term 'modules' has a lot of meanings"). I don't want to be too nit-picky - the sentences are all understandabl

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added a comment. In D131062#3697193 , @Mordante wrote: > Thanks a lot for working on this! > > I wonder whether it would be better to have some of the more technical > information in a separate file and let this file mainly have an introduction

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:377-393 + │ │ ││ + ├─ frontend ─┼─

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:18 + +There is already a detailed document about clang modules Modules_, it +should be helpful to read Modules_ if you want to know more about the general Mordante wrote: > Is `Modules

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 449898. ChuanqiXu marked 15 inline comments as done. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. - Address comments. - Tested with `make docs-clang-html`. - Add `Known Problems` section. CHANGES SINCE LAST ACTION https://rev

[PATCH] D131062: [docs] Add "C++20 Modules"

Mordante added a comment. Thanks a lot for working on this! I wonder whether it would be better to have some of the more technical information in a separate file and let this file mainly have an introduction to modules in general and how to get started using them in Clang. I haven't tested the

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu updated this revision to Diff 449657. ChuanqiXu added a comment. Remove the discussion about the difference about macro in clang module and header units since we need more discussion about it. And the discussion is not necessary about the docs. CHANGES SINCE LAST ACTION https://rev

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:468-469 + +(This may be an implementation defect. Although we could argue that header units have no name according to the spec, +it is natural that we couldn't search it. But this is not user friendly

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu added inline comments. Comment at: clang/docs/CPlusPlus20Modules.rst:377-393 + │ │ ││ + ├─ frontend ─┼─

[PATCH] D131062: [docs] Add "C++20 Modules"

ChuanqiXu created this revision. ChuanqiXu added reviewers: iains, urnathan, erichkeane, aaron.ballman, tahonermann, ilya-biryukov, Mordante, tschuett, philnik. ChuanqiXu added projects: clang-modules, clang-language-wg. Herald added a subscriber: arphaman. Herald added a project: All. ChuanqiXu r