[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-03 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin updated this revision to Diff 449572. prehistoric-penguin added a comment. Format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-replacem

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-03 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin added inline comments. Comment at: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:140 +// This replacement is a duplicate of one suggested by another TU. +if (!InsertPos.second) { return; --

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-03 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin updated this revision to Diff 449570. prehistoric-penguin added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-03 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin updated this revision to Diff 449569. prehistoric-penguin added a comment. Fix per comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-replac

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-03 Thread Adrian Vogelsgesang via Phabricator via cfe-commits
avogelsgesang added inline comments. Comment at: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:140 +// This replacement is a duplicate of one suggested by another TU. +if (!InsertPos.second) { return; Pre

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

2022-08-02 Thread ppenguin via Phabricator via cfe-commits
prehistoric-penguin created this revision. prehistoric-penguin added reviewers: Sockke, avogelsgesang, njames93, harlanhaskins, hokein, alexfh. Herald added a project: All. prehistoric-penguin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: