[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-28 Thread Sam Estep via Phabricator via cfe-commits
samestep added a comment. Here is the new patch: D130726 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm.org/D130593 ___ cfe-commits mail

[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-27 Thread Sam Estep via Phabricator via cfe-commits
samestep added a comment. Note: after some discussion with @ymandel, we've decided to adjust our design for this. A new patch is on the way which will replace this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm

[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-26 Thread Sam Estep via Phabricator via cfe-commits
samestep added a comment. In D130593#3681126 , @xazax.hun wrote: > While separate call strings are properly isolated from each other, repeated > analysis of the same call is not:| > > while (...) > { > foo(...); > } > > In the above code snippe

[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-26 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. While separate call strings are properly isolated from each other, repeated analysis of the same call is not:| while (...) { foo(...); } In the above code snippet, we will end up analyzing foo with leftover state from the previous iteration. The analysis ca

[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-26 Thread Sam Estep via Phabricator via cfe-commits
samestep updated this revision to Diff 447808. samestep added a comment. Use operator[] instead of try_emplace for C++14 compatibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130593/new/ https://reviews.llvm.org/D130593 Files: clang/includ

[PATCH] D130593: [clang][dataflow] Separate context by frame

2022-07-26 Thread Sam Estep via Phabricator via cfe-commits
samestep created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. samestep requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep