[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-29 Thread Rainer Orth via Phabricator via cfe-commits
ro abandoned this revision. ro added a comment. Nick Clifton just commited a fix both to the binutils 2.39 branch and master. So the workaround certainly isn't necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.l

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-28 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. In D130566#3682923 , @dblaikie wrote: >> This is all extremely weird, but until the error shows up again, I'll put >> this patch on hold (not yet abandoning since there seems to be no way to >> unabandon if necessary). > > You can ab

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. I'll flag this as "request changes" so we're clear the issue isn't fully understood nor fully reproducible - so once there's some more data on the scope/impact/cause/timeline for

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-27 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. I accepted this because this seems a major showstopper and we want to resolve it for the upcoming major release But I just recall that clang 14.0.0 has defaulted to DWARF v5 for most ELF operating systems on all architectures. > So far, I had only seen it with the GNU l

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > This is all extremely weird, but until the error shows up again, I'll put > this patch on hold (not yet abandoning since there seems to be no way to > unabandon if necessary). You can abandon and then "reclaim" the revision to reopen it and continue work. Repositor

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-27 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. In D130566#3681129 , @dblaikie wrote: >> During a build on Debian 11/sparc64, several binaries fail to link with >> >> /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: >> 0x23 > > What's the linker doing parsi

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-26 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > During a build on Debian 11/sparc64, several binaries fail to link with > > /usr/bin/ld: /usr/bin/ld: DWARF error: invalid or unhandled FORM value: 0x23 What's the linker doing parsing DWARF? Any idea what feature this is? And why is it SPARC-specific? Or is it true

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Consider creating a minimum reproduce and filing a bug on https://sourceware.org/bugzilla/buglist.cgi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.llvm.org/D1305

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-26 Thread Rainer Orth via Phabricator via cfe-commits
ro added a comment. In D130566#3679480 , @glaubitz wrote: > Interesting and thanks for catching this! How did you discover this issue? Is > there any particular program that fails to build due to this issue? Sure: many programs fail to link during `ninj

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-26 Thread John Paul Adrian Glaubitz via Phabricator via cfe-commits
glaubitz added a comment. Interesting and thanks for catching this! How did you discover this issue? Is there any particular program that fails to build due to this issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130566/new/ https://reviews.l

[PATCH] D130566: [Driver] Default to DWARF 4 on Linux/sparc64

2022-07-26 Thread Rainer Orth via Phabricator via cfe-commits
ro created this revision. ro added reviewers: glaubitz, MaskRay. ro added a project: clang. Herald added subscribers: jsji, StephenFan, pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. During a build on Debian 11/sparc64, several binaries fail to