This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3281138aad80: [clang][dataflow] Fix SAT solver crashes on `X
^ X` and `X v X` (authored by gribozavr).
Repository:
rG LLVM Github Monorepo
CHANGE
gribozavr updated this revision to Diff 447609.
gribozavr added a comment.
Actually visit a subexpression
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130522/new/
https://reviews.llvm.org/D130522
Files:
clang/lib/Analysis/FlowSensitive/WatchedL
sgatev accepted this revision.
sgatev added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:273
+
+// Visit a sub-value of `Val` (pick any, they are identical).
+ } else {
Let's visit `C->getLeftSubValue()` her
gribozavr created this revision.
Herald added subscribers: martong, tschuett, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
gribozavr requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
BooleanFormula::addClause has an i