ckissane added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004
// consumers will not want its contents.
+ llvm::compression::CompressionAlgorithm CompressionScheme =
+ llvm::compression::ZlibCompressionAlgorithm();
+
dblaikie
dblaikie added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004
// consumers will not want its contents.
+ llvm::compression::CompressionAlgorithm CompressionScheme =
+ llvm::compression::ZlibCompressionAlgorithm();
+
ckissane
ckissane added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004
// consumers will not want its contents.
+ llvm::compression::CompressionAlgorithm CompressionScheme =
+ llvm::compression::ZlibCompressionAlgorithm();
+
dblaikie
MaskRay added a comment.
Thanks for experimenting the refactoring. My gut feeling is that
- for inheritance `llvm/lib/Support/Compression.cpp` introduces quite a bit of
complexity.
- BestSpeedCompression/DefaultCompression/BestSizeCompression may be kinda
weird. Not all algorithms may need all
dblaikie added inline comments.
Comment at: clang/lib/Serialization/ASTWriter.cpp:2003-2004
// consumers will not want its contents.
+ llvm::compression::CompressionAlgorithm CompressionScheme =
+ llvm::compression::ZlibCompressionAlgorithm();
+
Doesn't
ckissane updated this revision to Diff 447469.
ckissane added a comment.
- format
- merge fix
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130516/new/
https://reviews.llvm.org/D130516
Files:
clang-tools-extra/clangd/index/Serialization.cpp
cl
ckissane created this revision.
ckissane added a reviewer: dblaikie.
Herald added subscribers: wenlei, usaxena95, kadircet, arphaman, hiraditya,
arichardson, emaste.
Herald added a reviewer: alexander-shaposhnikov.
Herald added a reviewer: rupprecht.
Herald added a reviewer: jhenderson.
Herald add
