This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbfe191dfa79b: Disable stack-sizes section by default for
PS4. (authored by MaggieYi).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
MaggieYi updated this revision to Diff 447756.
MaggieYi added a comment.
Use `Args.addOptInFlag` instead of `Args.hasFlag`, thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130493/new/
https://reviews.llvm.org/D130493
Files:
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Dri
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5883
if (Args.hasFlag(options::OPT_fstack_size_section,
- options::OPT_fno_stack_size_section, RawTriple.isPS4()))
+ options::OPT_fno_stack_size_section, false)
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130493/new/
https://reviews.llvm.org/D130493
_
MaggieYi created this revision.
MaggieYi added reviewers: probinson, wristow.
Herald added a project: All.
MaggieYi requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
Change Clang's default so that -fstack-size-section is no longer ena
