This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGba198e35fd38: [NFC] Fix some C++20 warnings (authored by
Godin, committed by steakhal).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
Godin added a comment.
@aaron.ballman thanks for the review! could you please commit this on my
behalf since I do not have commit rights?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130476/new/
https://reviews.llvm.org/D130476
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130476/new/
https://reviews.llvm.org/D130476
_
Godin created this revision.
Herald added a project: All.
Godin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Without this patch when using CMAKE_CXX_STANDARD=20 Microsoft compiler produces
following warnings
clang\include\clang/Basic/D
