[PATCH] D130419: Use `` with MSVC and C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba49d39b20cc: Use `` with MSVC and C++ (authored by fsb4000, committed by Mordante). Changed prior to commit: https://reviews.llvm.or

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447388. fsb4000 added a comment. Thanks. I already asked Mark de Wever. My name, email: Igor Zhukov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 Files: clang/d

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman added a comment. In D130419#3676736 , @Mordante wrote: > In D130419#3676654 , @aaron.ballman > wrote: > >> In D130419#3676643 , @fsb4000 >> wrote: >> >>> d

[PATCH] D130419: Use `` with MSVC and C++

Mordante accepted this revision. Mordante added a comment. This revision is now accepted and ready to land. In D130419#3676654 , @aaron.ballman wrote: > In D130419#3676643 , @fsb4000 wrote: > >> drop the dummy fi

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman added a comment. In D130419#3676643 , @fsb4000 wrote: > drop the dummy file and update the release notes. Thanks! I forgot to ask -- do you need someone to commit on your behalf? If so, what name and email address would you like used for p

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447377. fsb4000 added a comment. drop the dummy file and update the release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 Files: clang/docs/ReleaseNotes.rs

[PATCH] D130419: Use `` with MSVC and C++

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM (be sure to drop the dummy file before landing), but please add a release note mentioning the fix as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 updated this revision to Diff 447163. fsb4000 added a comment. Herald added a subscriber: libcxx-commits. Herald added 1 blocking reviewer(s): libc++. added a dummy.txt in libcxx directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419

[PATCH] D130419: Use `` with MSVC and C++

Mordante added a comment. Can you add a dummy file in the libc++ subdirectory? That should trigger the libc++ pre-commit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 __

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. Good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D130419: Use `` with MSVC and C++

mizvekov added a comment. In D130419#3673877 , @fsb4000 wrote: > Why did x64 debian tests fail? openmp build is broken on linux pre-commit CI right now. Not related to your patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. Why did x64 debian tests fail? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 added a comment. F23880823: изображение.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130419/new/ https://reviews.llvm.org/D130419 ___ cfe-commits mailing

[PATCH] D130419: Use `` with MSVC and C++

fsb4000 created this revision. fsb4000 added a project: clang. Herald added a project: All. fsb4000 requested review of this revision. Herald added a subscriber: cfe-commits. and use fallback only for C. It fixes the isssue with clang-cl: #include #include #ifdef __cplusplus #include