cor3ntin added inline comments.
Comment at: clang/lib/Lex/Lexer.cpp:1490-1492
static const llvm::sys::UnicodeCharSet XIDStartChars(XIDStartRanges);
// '_' doesn't have the XID_Start property but is allowed in C++.
return C == '_' || XIDStartChars.contains(C);
-
tahonermann added a comment.
Apologies for the much delayed review (I know this already landed).
I added a comment, but I don't know if there is actually an issue to be fixed.
This looks good to me otherwise.
Comment at: clang/lib/Lex/Lexer.cpp:1490-1492
static const llv
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaee76cb59ca2: [Clang] Add support for Unicode identifiers
(UAX31) in C2x mode. (authored by cor3ntin).
Repository:
rG LLVM Github Monorepo
CHANGE
cor3ntin updated this revision to Diff 447056.
cor3ntin added a comment.
Fix typo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130416/new/
https://reviews.llvm.org/D130416
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Lex/Lexer.cpp
clang/tes
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a typo fix in a comment. One thing worth thinking about is
whether it would be worth it to have a diagnostic for valid C code in older
modes that will change beha
cor3ntin updated this revision to Diff 447051.
cor3ntin added a comment.
Update a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130416/new/
https://reviews.llvm.org/D130416
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Lex/Lexer.cpp
c
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This implements
N2836 Identifier Syntax using Unicode Standard Annex 31.
The feature was already implemented for C++,
and
