[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. In D130322#3672362 , @MaskRay wrote: > Testing and will push in one minute Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37502e042ff0: [clang][CodeGen] Only include ABIInfo.h where required (NFC) (authored by barannikov88, committed by MaskRay). Changed prior to commit

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

MaskRay added a comment. Testing and will push in one minute Comment at: clang/lib/CodeGen/CGObjCRuntime.h:37 namespace CodeGen { + class CGFunctionInfo; class CodeGenFunction; The style is to remove indentation. I'll fix it. Repository: rG LLVM Github

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. @MaskRay Would you please merge it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ABIInfo.h:39 -namespace swiftcall { - class SwiftAggLowering; -} Not used in this file. (This class does not seem to be used anywhere.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 updated this revision to Diff 446685. barannikov88 added a comment. Removed forward declaration of non-existent class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 Files: clang/lib/CodeG

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added a comment. To reviewers: if you are OK with the patch, could you please merge it? I don't have permission yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130322/new/ https://reviews.llvm.org/D130322 _

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.h:49 public: - TargetCodeGenInfo(std::unique_ptr Info) : Info(std::move(Info)) {} + TargetCodeGenInfo(std::unique_ptr Info); virtual ~TargetCodeGenInfo(); Had to do this due to "in

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGCall.h:26 -// FIXME: Restructure so we don't have to expose so much stuff. -#include "ABIInfo.h" - This is the main change. The included file was not used here at all. Repository: rG LLVM Git

[PATCH] D130322: [clang][CodeGen] Only include ABIInfo.h where required

barannikov88 created this revision. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130322 Files: clang/lib/CodeGen/CGBuiltin.cpp