This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb5871dfaf318: [clangd] Refactor forwarding call detection
logic (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130261/new/
https://reviews.llvm.org/D130261
_
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1446
+void bax(Args... args) { foo({args...}, args...); }
+
+void foo() {
ilya-biryukov wrote:
> NIT: maybe test for the case with a single expansion here:
>
kadircet updated this revision to Diff 446529.
kadircet marked 4 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130261/new/
https://reviews.llvm.org/D130261
Files:
clang-tools-
ilya-biryukov requested changes to this revision.
ilya-biryukov added a comment.
This revision now requires changes to proceed.
The new test fails in the pre merge checks.
Maybe the diff is missing some more changes?
Comment at: clang-tools-extra/clangd/AST.cpp:794
}
kadircet created this revision.
kadircet added a reviewer: ilya-biryukov.
Herald added subscribers: usaxena95, arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang-tools-extra.
Repository:
