This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0ecb4a2991d: [HLSL] Move DXIL validation version out of
ModuleFlags (authored by python3kgae).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130207/new/
ht
python3kgae updated this revision to Diff 455817.
python3kgae marked 3 inline comments as done.
python3kgae added a comment.
Remove empty function and replace auto with correct type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130207/new/
https:/
beanz added a comment.
A few nitpicks, otherwise this looks good.
Comment at: llvm/lib/Target/DirectX/DXILTranslateMetadata.cpp:61
-static void cleanModuleFlags(Module &M) {
- constexpr StringLiteral DeadKeys[] = {ValVerKey};
- // Collect DeadKeys in ModuleFlags.
- StringS
python3kgae created this revision.
python3kgae added reviewers: Anastasia, kuhar, bogner, beanz, pow2clk.
Herald added a subscriber: hiraditya.
Herald added a project: All.
python3kgae requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe
