[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

2022-07-26 Thread David Goldman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG88a2ac6ad623: [clangd] Improve XRefs support for ObjCMethodDecl (authored by dgoldman). Changed prior to commit: https://reviews.llvm.org/D130095?vs=445951&id=447739#toc Repository: rG LLVM Github Mo

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

2022-07-25 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/XRefs.cpp:89 + return MD; +auto *DeclCtx = cast(MD->getDeclContext()); +if (DeclCtx->isInvalidDecl())

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

2022-07-19 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 445951. dgoldman added a comment. Minor grammar update to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-t

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

2022-07-19 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 445873. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

2022-07-19 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - C