[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. I see what is going on here. The problem is not in this patch, but there is a problem in update_cc_test_checks.py. I had all the other files in `clang/test/utils/update_cc_test_checks` still checked out as unix line endings from before I had updated the config, and tha

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668111 , @nhaehnle wrote: > My version of `diff` has a `--strip-trailing-cr` flag. But I don't really see > that being used in many places at all. What I see is that the sources are checked out with the expected win

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. My version of `diff` has a `--strip-trailing-cr` flag. But I don't really see that being used in many places at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130089/new/ https://reviews.llvm.org/D130089

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668061 , @nhaehnle wrote: > I've been staring at ifdef.test vs. basic-cplusplus.test for a while now and > don't see any relevant difference, including when I look at the line endings > in a hex editor (on Linux). S

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. I've been staring at ifdef.test vs. basic-cplusplus.test for a while now and don't see any relevant difference, including when I look at the line endings in a hex editor (on Linux). So I guess there is a difference that appears only on Windows somehow? Unfortunately, I

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. In D130089#3668022 , @nhaehnle wrote: > Aren't the before and after lines of the diff identical? Is this a Windows > new-lines issue? Yeah it looks like it from a glance, but I haven't had time to take a harder look at this ye

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added a comment. In D130089#3666076 , @mizvekov wrote: > This seems to have introduced a test which always fails on windows: > > $ ":" "RUN: at line 4" > $ "cp" "clang\test\utils\update_cc_test_checks/Inputs/ifdef.c" > "build\llvm\tools\clan

[PATCH] D130089: update-test-checks: safely handle tests with #if's

mizvekov added a comment. This seems to have introduced a test which always fails on windows: $ ":" "RUN: at line 4" $ "cp" "clang\test\utils\update_cc_test_checks/Inputs/ifdef.c" "build\llvm\tools\clang\test\utils\update_cc_test_checks\Output\ifdef.test.tmp.c" $ "C:/Program Files (x86)/Mi

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle added inline comments. Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll:2 ; Check that we accept functions with '$' in the name. ; TODO: This is not handled correcly on 32bit ARM and needs to be fixed.

[PATCH] D130089: update-test-checks: safely handle tests with #if's

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. nhaehnle marked an inline comment as done. Closed by commit rG5a4033c36716: update-test-checks: safely handle tests with #if's (authored by nhaehnle). Changed prior to

[PATCH] D130089: update-test-checks: safely handle tests with #if's

arichardson accepted this revision. arichardson added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/arm_function_name.ll:2 ; Check that we accept functions with '$' in the name. ; TO

[PATCH] D130089: update-test-checks: safely handle tests with #if's

nhaehnle created this revision. nhaehnle added reviewers: MaskRay, arsenm, aemerson, arichardson. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. nhaehnle requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added projects: clang,