[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

amyk added a comment. In D130066#3670875 , @sammccall wrote: > In D130066#3670745 , @amyk wrote: > >> Hi! >> >> It appears that this patch is causing a build failure on a couple PPC bots >> that build with shared

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall added a comment. In D130066#3670745 , @amyk wrote: > Hi! > > It appears that this patch is causing a build failure on a couple PPC bots > that build with shared libraries: > https://lab.llvm.org/buildbot/#/builders/57/builds/20179 > https://lab

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

amyk added a comment. Hi! It appears that this patch is causing a build failure on a couple PPC bots that build with shared libraries: https://lab.llvm.org/buildbot/#/builders/57/builds/20179 https://lab.llvm.org/buildbot/#/builders/121/builds/21678 The specific error that occurs looks like thi

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall added inline comments. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:102 llvm::StringRef Name = G.table().AttributeValues[EID]; - assert(!Name.empty()); Out.os() << llvm::formatv("EXTENSION({0}, {1})\n", Name, EID); hokein wrote:

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

This revision was automatically updated to reflect the committed changes. sammccall marked 6 inline comments as done. Closed by commit rG3132e9cd7c9f: [pseudo] Key guards by RuleID, add guards to literals (and 0). (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D13006

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. it looks good. Comment at: clang-tools-extra/pseudo/gen/Main.cpp:102 llvm::StringRef Name = G.table().AttributeValues[EID]; - assert(!Name.empty()); Out.os

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall updated this revision to Diff 446061. sammccall added a comment. rebase on function-declarator guards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130066/new/ https://reviews.llvm.org/D130066 Files: clang-tools-extra/pseudo/gen/Main.c

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall updated this revision to Diff 445760. sammccall added a comment. reorder a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130066/new/ https://reviews.llvm.org/D130066 Files: clang-tools-extra/pseudo/gen/Main.cpp clang-tools-extra/

[PATCH] D130066: [pseudo] Key guards by RuleID, add guards to literals (and 0).

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added a project: clang-tools-extra. After this, NUMERIC_CONSTANT and strings should parse only