This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5dbb92d8cdf7: [HLSL] CodeGen HLSL Resource annotations
(authored by beanz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130019/new/
https://reviews.llvm.org/D130019
beanz updated this revision to Diff 449014.
beanz added a comment.
Updates based on PR feedback. Thanks @aaron.ballman!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130019/new/
https://reviews.llvm.org/D130019
Files:
clang/lib/CodeGen/CGDeclCXX
aaron.ballman added inline comments.
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:59
+return;
+ auto *RD = Ty->getAsCXXRecordDecl();
+ if (!RD)
Comment at: clang/lib/CodeGen/CGHLSLRuntime.cpp:62-66
+ if (!RD->hasAttr())
+return;
beanz updated this revision to Diff 445572.
beanz added a comment.
Updating based on feedback from @python3kgae provided via chat. Because of the
odd nature of DXIL, the DirectX backend needs to filter the module flags, for
that reason it is easier to use a named metadata entry which can just be
beanz created this revision.
beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae.
Herald added a project: All.
beanz requested review of this revision.
Herald added a project: clang.
HLSL Resource types need special annotations that the backend will use
to build out metadat
