[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

2022-07-28 Thread Chris Bieneman via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe13002bb37c: [HLSL] Add __builtin_hlsl_create_handle (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

2022-07-18 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} python3kgae wrote: > What does the parameter 0 mean here? > For the purposes of this test, the value doesn't m

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

2022-07-18 Thread Xiang Li via Phabricator via cfe-commits
python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/create_handle.hlsl:4 +void fn() { + (void)__builtin_hlsl_create_handle(0); +} What does the parameter 0 mean here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130016: [HLSL] Add __builtin_hlsl_create_handle

2022-07-18 Thread Chris Bieneman via Phabricator via cfe-commits
beanz created this revision. beanz added reviewers: aaron.ballman, Anastasia, kuhar, bogner, python3kgae. Herald added a project: All. beanz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: llvm-commits. This is pretty straightforward, it just adds