This revision was automatically updated to reflect the committed changes.
Closed by commit rGdf537bef6393: Use pseudoparser-based folding ranges in
ClangdServer. (authored by usaxena95).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130011/new/
http
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
The change looks good to me.
> as discussed offline i don't see much value in having an extra flag to choose
> between ast-based and pseudo-based implementation, as the pseudo-based one is
>
usaxena95 added a comment.
Let us land this after the branch cut then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130011/new/
https://reviews.llvm.org/D130011
___
cfe-commits mailing list
cfe-commits@
usaxena95 updated this revision to Diff 445547.
usaxena95 added a comment.
Removed option to fallback to AST based implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130011/new/
https://reviews.llvm.org/D130011
Files:
clang-tools-extr
kadircet added a comment.
as discussed offline i don't see much value in having an extra flag to choose
between ast-based and pseudo-based implementation, as the pseudo-based one is a
super-set of the ast-based implementation. hence it shouldn't be regressing
change in any way, therefore i am i
usaxena95 created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
usaxena95 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Monorepo
