[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

This revision was automatically updated to reflect the committed changes. Closed by commit rG028717014002: [clang][deps] Include canonical invocation in ContextHash (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir updated this revision to Diff 448370. benlangmuir added a comment. - Added comments to tests - Added a missing test that I accidentally deleted - Rebased on latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/ https://r

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

jansvoboda11 added a comment. Makes sense, thanks. LGTM provided you add brief explanation to each of the new tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/ https://reviews.llvm.org/D129884 __

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir added a comment. In D129884#3677435 , @jansvoboda11 wrote: > Would it make sense for this to replace the existing strict context hash > implementation? It's not clear to me whether this would be a good tradeoff or not: the explicit build c

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

jansvoboda11 added a comment. Would it make sense for this to replace the existing strict context hash implementation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129884/new/ https://reviews.llvm.org/D129884

[PATCH] D129884: [clang][deps] Include canonical invocation in ContextHash

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, Bigcheese, akyrtzi. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The "strict context hash" is insufficient to identify