[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-26 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Abandon this since we're prefer D130331 , thanks for every one here! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129748/new/ https://reviews.llvm.org/D129748 _

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D129748#3668446 , @erichkeane wrote: > In D129748#3667932 , @ChuanqiXu > wrote: > >> @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell >> the user honestly

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-21 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D129748#3667932 , @ChuanqiXu wrote: > @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell the > user honestly that we couldn't handle it (temporarily). We could still > modularize the STL by a trick:

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. @erichkeane @aaron.ballman @tahonermann I get another idea. We could tell the user honestly that we couldn't handle it (temporarily). We could still modularize the STL by a trick: https://github.com/ChuanqiXu9/stdmodules/blob/e81f4e9e74f96021f2e45c48f44da93e806c4524/M

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D129748#3666511 , @tahonermann wrote: > I can imagine several ways in which things may be going wrong. Perhaps > (de)serialization is switching to a canonical declaration when it should not > be (e.g., reading/writing a de

[PATCH] D129748: [C++20] [Modules] Warn for the use of preferred_name in modules

2022-07-21 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu updated this revision to Diff 446404. ChuanqiXu retitled this revision from "[Modules] Disable preferred_name attribute in C++20 Modules" to "[C++20] [Modules] Warn for the use of preferred_name in modules". ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Don'