[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabc8f2b7245f: [Driver] Don't passs --dynamic-linker in -r mode (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad updated this revision to Diff 444791. brad added a comment. Disable -pie when using -r. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 Files: clang/lib/Driver/ToolChains/Ananas.cpp clang/lib/Dri

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ https://reviews.llvm.org/D129714 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

MaskRay added a comment. `-r -pie` feels like an error to me. `gcc -dumpspecs` uses `%{static|shared|r:;!no-pie:-pie}`, which means `-r` overrides `-pie`. Either match the behavior if report an error. If reporting an error adds too much complexity, just match the behavior. We just shouldn't let

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. One question, should the backends be passing -pie when using -r? I had adjusted the tests but cannot remember why I had changed the logic of the backend before submitting the diff. I had originally had -pie disabled with -r for Ananas and NetBSD. I noticed Fuchsia had...

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad added a comment. In D129714#3650371 , @MaskRay wrote: > Thanks! This is trivially correct but consider giving folks one day to > respond. Sure thing. No problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! This is trivially correct but consider giving folks one day to respond. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129714/new/ http

[PATCH] D129714: [Driver] Don't passs --dynamic-linker in -r mode

brad created this revision. brad added reviewers: MaskRay, emaste, zhmu, mgorny, phosek. brad added a project: clang. Herald added subscribers: abrachet, StephenFan. Herald added a project: All. brad requested review of this revision. As mentioned in commit 57e43ebc42d4e572cab1e84532115c364d5db92a