This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd2792e7d37c4: [clang][test] fix typo in fn attr (authored by
nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ht
nickdesaulniers updated this revision to Diff 444695.
nickdesaulniers added a comment.
- don't reset captured vars, that was a copy+paste mistake I made in the
original patch
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129691/new/
https://review
erichkeane accepted this revision.
erichkeane added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129691/new/
https://reviews.llvm.org/D129691
___
cfe-commits mailing list
cfe-commits@lis
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129691/new/
https://reviews.llvm.org/D129691
nickdesaulniers added inline comments.
Comment at: clang/test/CodeGen/attr-function-return.c:18
// CHECK: @keep2() [[KEEP:#[0-9]+]]
[[gnu::function_return("keep")]] void keep2(void) {}
probably don't want to reset `KEEP`
Comment at: clang/t
nickdesaulniers created this revision.
nickdesaulniers added reviewers: aaron.ballman, erichkeane, MaskRay.
Herald added subscribers: jsji, StephenFan, pengfei.
Herald added a project: All.
nickdesaulniers requested review of this revision.
Herald added a project: clang.
Herald added a subscriber:
