[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-08-31 Thread Tom Honermann via Phabricator via cfe-commits
tahonermann added a comment. > While accepting all these inside of string and character literals in C and > C++20 and older is fine, accepting them inside of identifiers can change > meaning of valid programs. Thank you for reporting this impact, @jakubjelinek! I'll copy you on an email to WG2

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-08-31 Thread Jakub JelĂ­nek via Phabricator via cfe-commits
jakubjelinek added a comment. While accepting all these inside of string and character literals in C and C++20 and older is fine, accepting them inside of identifiers can change meaning of valid programs. https://gcc.gnu.org/pipermail/gcc-patches/2022-August/600620.html #define z(x) 0 #define a

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-07-13 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6882ca9aff07: [Clang] Adjust extension warnings for delimited sequences (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ ht

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-07-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! If for some very surprising reason either of these papers fail in plenary, we can easily revert this as necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-07-13 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. @aaron.ballman I think we might as well do that now, and revert if WG21 does some funny business in plenary. WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ https://reviews.llvm.org/D129664 __

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-07-13 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin updated this revision to Diff 444322. cor3ntin added a comment. Forgot to format! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129664/new/ https://reviews.llvm.org/D129664 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D129664: [Clang] Adjust extension warnings for delimited sequences

2022-07-13 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WG21 approved delimited escape sequences and named escape sequences. Adjust the extension warnings accordingly, and update