[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-18 Thread Utkarsh Saxena via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG70914aa63156: Use pseudo parser for folding ranges (authored by usaxena95). Changed prior to commit: https://reviews.llvm.org/D129648?vs=445002&id=445432#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-18 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 ___

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-15 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 445002. usaxena95 added a comment. Removed unused headers and fix spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMake

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-15 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:185 +if (auto *Paired = Tok.pair()) { + if (Tok.Line < Paired->Line) { +Position Start = offsetToPosition( hokein wrote: > The `if` logic seems tricky, it

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-15 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 444975. usaxena95 marked 15 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-t

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:149 +target_include_directories(clangDaemon PUBLIC + ${CMAKE_CURRENT_SOURCE_DIR}/../pseudo/include +) It should rather be up to the clangPseudo target to specify its include di

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:175 + + llvm::Optional Preprocessed; + Preprocessed = DirectiveStructure.stripDirectives(OrigStream); nit: no need to use llvm::Optional. Comment at: cla

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-14 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 444765. usaxena95 added a comment. Removed changes from previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLi

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-14 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 updated this revision to Diff 444755. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLists.txt cl

[PATCH] D129648: Use pseudo parser for folding ranges

2022-07-13 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 created this revision. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For sharing. WIP Repository: rG LLVM Github Monore