MaskRay added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129594/new/
https://reviews.llvm.org/D129594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaf58684f2720: [InstrProf] Add options to profile function
groups (authored by ellis).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129594/new/
https://revi
ianlevesque accepted this revision.
ianlevesque added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129594/new/
https://reviews.llvm.org/D129594
_
ellis updated this revision to Diff 444327.
ellis added a comment.
Use `crc32` rather than `md5` to compute function hashes faster.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129594/new/
https://reviews.llvm.org/D129594
Files:
clang/docs/Clan
ellis added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2871
+ if (NumGroups > 1) {
+auto Group = llvm::MD5Hash(Fn->getName()) % NumGroups;
+if (Group != getCodeGenOpts().ProfileSelectedFunctionGroup)
ianlevesque wrote:
> In D87953 I
ianlevesque added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2871
+ if (NumGroups > 1) {
+auto Group = llvm::MD5Hash(Fn->getName()) % NumGroups;
+if (Group != getCodeGenOpts().ProfileSelectedFunctionGroup)
In D87953 I used crc32 to
ellis created this revision.
Herald added a subscriber: Enna1.
Herald added a project: All.
ellis edited the summary of this revision.
ellis added reviewers: ianlevesque, kyulee, MaskRay, phosek, wenlei, davidxl.
Herald added a subscriber: StephenFan.
ellis updated this revision to Diff 444091.
ell
