This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG632de855a042: [clang][dataflow] Refactor boolean creation as
a test utility. (authored by wyt).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
wyt updated this revision to Diff 444031.
wyt added a comment.
Removed unused imports in SolverTest.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129546/new/
https://reviews.llvm.org/D129546
Files:
clang/unittests/Analysis/FlowSensitive/Solv
wyt updated this revision to Diff 444026.
wyt marked an inline comment as done.
wyt added a comment.
Address comments: add used import, remove unused imports.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129546/new/
https://reviews.llvm.org/D12954
sgatev accepted this revision.
sgatev added inline comments.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:263
+private:
+ std::vector> Vals;
+};
`#include `
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
wyt updated this revision to Diff 443938.
wyt marked 2 inline comments as done.
wyt added a comment.
Address comments on renaming. Removed test fixture class, replacing TEST_F with
TEST.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129546/new/
ht
gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:223
+/// Utility class for creating boolean values.
+class BoolValueManager {
--
wyt created this revision.
Herald added subscribers: martong, tschuett, xazax.hun.
Herald added a project: All.
wyt requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D129546
Fil
